Allow roundtripping damage in folded vehicle items#60710
Merged
dseguin merged 3 commits intoCleverRaven:masterfrom Sep 7, 2022
Merged
Allow roundtripping damage in folded vehicle items#60710dseguin merged 3 commits intoCleverRaven:masterfrom
dseguin merged 3 commits intoCleverRaven:masterfrom
Conversation
1789d63 to
7c32e43
Compare
7c32e43 to
be40dc0
Compare
BevapDin
reviewed
Sep 5, 2022
be40dc0 to
9a4eac8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Fixes #60700
Describe the solution
On folding calculate average part damage and serialize into item_var and item itself.
On unfolding get the difference between current item and old item_var damage;
Start applying it to random parts in chunks
be40dc0 also fixes a couple more MSVC warnings I missed in #60568
Note that I had need for a random-looking sequence with fixed seed - I don't need it to actually be random, just so parts "look" randomly damaged in a way that tests can snapshot (and so don't rely on global rng state) and there seems to be none existing - so I added one into rng.h/cpp
Describe alternatives you've considered
Using one of the simple hashes available for the rng sequence, but it'd do the same job but with extra steps and possible bugs.
Testing
Spawn and kill zombie granny, unfold wheelchair, parts should be damaged.
Unit test is added, could also run the unit test scenario manually
Additional context